Skip to content

Conversation

@saulshanabrook
Copy link
Member

No description provided.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 23, 2024

CodSpeed Performance Report

Merging #218 will degrade performances by 35.98%

Comparing update-benchmarks (eac2634) with main (12d8d5f)

Summary

❌ 2 regressions
✅ 5 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main update-benchmarks Change
test_source_optimized 3.9 s 6.1 s -35.98%
test_trace 1 s 1.2 s -17.73%

@saulshanabrook
Copy link
Member Author

This is quite a large slowdown, I believe from moving from eval to extract then eval.

I think it's worth it however, since I was thinking we probably want to move away from supporting eval anyways.

I think it would be good to try to speed up extract on primitives, it really shouldn't be this slow!

@saulshanabrook saulshanabrook merged commit a7a26d1 into main Oct 23, 2024
8 of 9 checks passed
@saulshanabrook saulshanabrook deleted the update-benchmarks branch October 23, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants